Perf: Define __slots__ in element classes to reduce memory usage of elements#555
Merged
adrien-berchet merged 4 commits intogeoalchemy:masterfrom May 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reduce memory usage for spatial element classes by defining slots to prevent dynamic attribute creation, while also updating benchmark parameters in tests for performance measurement.
- Updated benchmark parameter value from 350 to 100 in two test cases.
- Added slots declarations in element classes to optimize memory usage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/benchmarks/test_insert_select.py | Updated benchmark parameters to adjust test load conditions. |
| geoalchemy2/elements.py | Introduced slots for the base _SpatialElement and its subclasses to reduce memory usage. |
Comments suppressed due to low confidence (1)
tests/benchmarks/test_insert_select.py:294
- [nitpick] The benchmark parameter value has been reduced from 350 to 100; please verify that this change still adequately tests higher-load scenarios for performance.
pytest.param(100, marks=pytest.mark.long_benchmark),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.