Skip to content

Chore: Move reflection type registering#561

Merged
adrien-berchet merged 1 commit intogeoalchemy:masterfrom
adrien-berchet:move_reflection_registering
Jun 2, 2025
Merged

Chore: Move reflection type registering#561
adrien-berchet merged 1 commit intogeoalchemy:masterfrom
adrien-berchet:move_reflection_registering

Conversation

@adrien-berchet
Copy link
Copy Markdown
Member

No description provided.

@adrien-berchet adrien-berchet requested a review from Copilot June 2, 2025 08:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the reflection type registration logic from the central geoalchemy2/types module to the individual dialect files, streamlining the registration process.

  • Update connection handling in tests to use connect() instead of begin() while ensuring proper transaction rollback.
  • Remove redundant type registration from geoalchemy2/types/init.py and add corresponding registration in SQLite, PostgreSQL, and MySQL dialects.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/conftest.py Replaces engine.begin() with engine.connect() and adds try/finally blocks to manage transactions and engine disposal.
geoalchemy2/types/init.py Removes reflection type registration for spatial types to centralize this logic in dialect-specific files.
geoalchemy2/admin/dialects/sqlite.py Adds type registration for spatial types in SQLite reflection.
geoalchemy2/admin/dialects/postgresql.py Adds type registration for spatial types in PostgreSQL reflection.
geoalchemy2/admin/dialects/mysql.py Adds type registration for spatial types in MySQL reflection.

@adrien-berchet adrien-berchet merged commit d3c1d04 into geoalchemy:master Jun 2, 2025
8 checks passed
@adrien-berchet adrien-berchet deleted the move_reflection_registering branch June 2, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants