Chore: Move reflection type registering#561
Merged
adrien-berchet merged 1 commit intogeoalchemy:masterfrom Jun 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR moves the reflection type registration logic from the central geoalchemy2/types module to the individual dialect files, streamlining the registration process.
- Update connection handling in tests to use connect() instead of begin() while ensuring proper transaction rollback.
- Remove redundant type registration from geoalchemy2/types/init.py and add corresponding registration in SQLite, PostgreSQL, and MySQL dialects.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Replaces engine.begin() with engine.connect() and adds try/finally blocks to manage transactions and engine disposal. |
| geoalchemy2/types/init.py | Removes reflection type registration for spatial types to centralize this logic in dialect-specific files. |
| geoalchemy2/admin/dialects/sqlite.py | Adds type registration for spatial types in SQLite reflection. |
| geoalchemy2/admin/dialects/postgresql.py | Adds type registration for spatial types in PostgreSQL reflection. |
| geoalchemy2/admin/dialects/mysql.py | Adds type registration for spatial types in MySQL reflection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.