Fix (mysql): Fix failing test for MySQL dialect#567
Merged
adrien-berchet merged 5 commits intomasterfrom Aug 18, 2025
Merged
Conversation
This fixes the failing test 'tests/test_functional.py::TestInsertionORM::test_transform' for the MySQL dialect. The test was failing because it was using the `ST_AsEWKB` function, which is not available in MySQL. This was addressed by adding a compilation rule for `ST_AsEWKB` in `geoalchemy2/admin/dialects/mysql.py`. This rule makes `ST_AsEWKB` compile to `ST_AsWKB(ST_SRID(geom, srid))` for MySQL and MariaDB, which solves the issue of the missing function and the incorrect SRID.
for more information, see https://pre-commit.ci
This fixes the failing test 'tests/test_functional.py::TestInsertionORM::test_transform' for the MySQL dialect. The test was failing because it was using the `ST_AsEWKB` function, which is not available in MySQL. This was addressed by adding a compilation rule for `ST_AsEWKB` in `geoalchemy2/admin/dialects/mysql.py`. This rule makes `ST_AsEWKB` compile to `ST_AsWKB(ST_SRID(geom, srid))` for MySQL and MariaDB, which solves the issue of the missing function and the incorrect SRID. The `TransformedGeometry` decorator in the tests was also updated to correctly handle the SRID transformation by using the `load_dialect_impl` method to provide a dialect-specific implementation of the type.
for more information, see https://pre-commit.ci
adrien-berchet
changed the title
adrien-berchet
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the failing test 'tests/test_functional.py::TestInsertionORM::test_transform' for the MySQL dialect. The issue was that the test was using the
ST_AsEWKBfunction, which is not available in MySQL. This was addressed by adding a compilation rule forST_AsEWKBingeoalchemy2/admin/dialects/mysql.py. This rule makesST_AsEWKBcompile toST_AsWKB(ST_SRID(geom, srid))for MySQL and MariaDB, which solves the issue of the missing function and the incorrect SRID.Edit: the bot was quite wrong and its explanation should only be considered as a first lead.