Fix: NameError when importing geoalchemy2.shape without Shapely installed#586
Closed
Fix: NameError when importing geoalchemy2.shape without Shapely installed#586
Conversation
Co-authored-by: adrien-berchet <11536226+adrien-berchet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test for GeoAlchemy2 import without Shapely
Fix: NameError when importing geoalchemy2.shape without Shapely installed
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geoalchemy2.shaperaisedNameError: name 'shapely' is not definedon import when Shapely was not installed, becauseshapely.Geometrywas used as an eager type annotation whileshapelywas not bound in the module namespace.Changes
geoalchemy2/shape.py: Replace bareshapely.Geometrytype hints with aShapelyGeometryalias that is always defined — resolved fromshapely.Geometrywhen Shapely is available, or a no-op stub class at runtime when it isn't (gated withif not TYPE_CHECKING:to avoid confusing static analyzers).tests/test_shape.py: Addtest_import_without_shapelyregression test that blocks allshapely.*entries insys.modules, reloadsgeoalchemy2.shape, and asserts it loads cleanly withHAS_SHAPELY = False, then restores state.Checklist
This pull request is:
mainbranch and pass with the provided fix.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.