Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to be compatible with Spring Boot 3 by replacing deprecated APIs and migrating validation imports from javax to jakarta. Key changes include:
- Replacing HttpStatus with HttpStatusCode and updating switch semantics in ApplicationErrorGatewayFilterFactory.
- Updating Spring Security configuration to use lambda-based customizers with withDefaults() calls in multiple classes and tests.
- Migrating all javax.validation imports to their jakarta.validation counterparts in various modules.
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/src/main/java/org/georchestra/gateway/filter/global/ApplicationErrorGatewayFilterFactory.java | Updated HTTP status handling and simplified idempotence check syntax. |
| gateway/src/main/java/org/georchestra/gateway/security/ldap/LdapAuthenticationConfiguration.java | Changed HTTP basic and form login configuration to leverage withDefaults(). |
| gateway/src/main/java/org/georchestra/gateway/security/oauth2/OAuth2Configuration.java | Updated OAuth2 login configuration with lambda-based customization. |
| gateway/src/main/java/org/georchestra/gateway/security/accessrules/AccessRulesCustomizerTest.java | Modified test cases to align with new authorizeExchange(withDefaults()) initialization. |
| docker-compose.yml | Removed header service configuration. |
| gateway/src/main/java/org/georchestra/gateway/security/accessrules/AccessRulesCustomizer.java | Updated authorizeExchange initialization to support Spring Boot 3 APIs. |
| gateway/src/main/java/org/georchestra/gateway/security/GatewaySecurityConfiguration.java | Applied lambda-based configuration for csrf, headers, exception handling, form login, and logout. |
| gateway/src/main/java/org/geoserver/cloud/gateway/filter/RouteProfileGatewayFilterFactory.java | Migrated validation import from javax to jakarta. |
| gateway/src/main/java/org/georchestra/gateway/filter/headers/CookieAffinityGatewayFilterFactory.java | Migrated validation import from javax to jakarta. |
| gateway/src/main/java/org/georchestra/gateway/handler/predicate/QueryParamRoutePredicateFactory.java | Migrated validation import from javax to jakarta. |
| gateway/src/main/java/org/georchestra/gateway/security/GeorchestraGatewaySecurityConfigProperties.java | Migrated validation import from javax to jakarta. |
| gateway/src/main/java/org/geoserver/cloud/gateway/predicate/RegExpQueryRoutePredicateFactory.java | Migrated validation import from javax to jakarta. |
| gateway/src/main/java/org/georchestra/gateway/autoconfigure/app/RoutePredicateFactoriesAutoConfiguration.java | Added additional imports related to route building for Spring Boot 3. |
Files not reviewed (2)
- gateway/pom.xml: Language not supported
- pom.xml: Language not supported
Member
|
superseded by #190 ? |
Member
|
Closing as superseded by #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.