Skip to content

wip: trying to bump to spring boot 3#188

Closed
f-necas wants to merge 13 commits intomainfrom
spring-boot-3
Closed

wip: trying to bump to spring boot 3#188
f-necas wants to merge 13 commits intomainfrom
spring-boot-3

Conversation

@f-necas
Copy link
Copy Markdown
Collaborator

@f-necas f-necas commented Mar 18, 2025

No description provided.

@f-necas f-necas requested a review from Copilot March 18, 2025 14:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to be compatible with Spring Boot 3 by replacing deprecated APIs and migrating validation imports from javax to jakarta. Key changes include:

  • Replacing HttpStatus with HttpStatusCode and updating switch semantics in ApplicationErrorGatewayFilterFactory.
  • Updating Spring Security configuration to use lambda-based customizers with withDefaults() calls in multiple classes and tests.
  • Migrating all javax.validation imports to their jakarta.validation counterparts in various modules.

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gateway/src/main/java/org/georchestra/gateway/filter/global/ApplicationErrorGatewayFilterFactory.java Updated HTTP status handling and simplified idempotence check syntax.
gateway/src/main/java/org/georchestra/gateway/security/ldap/LdapAuthenticationConfiguration.java Changed HTTP basic and form login configuration to leverage withDefaults().
gateway/src/main/java/org/georchestra/gateway/security/oauth2/OAuth2Configuration.java Updated OAuth2 login configuration with lambda-based customization.
gateway/src/main/java/org/georchestra/gateway/security/accessrules/AccessRulesCustomizerTest.java Modified test cases to align with new authorizeExchange(withDefaults()) initialization.
docker-compose.yml Removed header service configuration.
gateway/src/main/java/org/georchestra/gateway/security/accessrules/AccessRulesCustomizer.java Updated authorizeExchange initialization to support Spring Boot 3 APIs.
gateway/src/main/java/org/georchestra/gateway/security/GatewaySecurityConfiguration.java Applied lambda-based configuration for csrf, headers, exception handling, form login, and logout.
gateway/src/main/java/org/geoserver/cloud/gateway/filter/RouteProfileGatewayFilterFactory.java Migrated validation import from javax to jakarta.
gateway/src/main/java/org/georchestra/gateway/filter/headers/CookieAffinityGatewayFilterFactory.java Migrated validation import from javax to jakarta.
gateway/src/main/java/org/georchestra/gateway/handler/predicate/QueryParamRoutePredicateFactory.java Migrated validation import from javax to jakarta.
gateway/src/main/java/org/georchestra/gateway/security/GeorchestraGatewaySecurityConfigProperties.java Migrated validation import from javax to jakarta.
gateway/src/main/java/org/geoserver/cloud/gateway/predicate/RegExpQueryRoutePredicateFactory.java Migrated validation import from javax to jakarta.
gateway/src/main/java/org/georchestra/gateway/autoconfigure/app/RoutePredicateFactoriesAutoConfiguration.java Added additional imports related to route building for Spring Boot 3.
Files not reviewed (2)
  • gateway/pom.xml: Language not supported
  • pom.xml: Language not supported

@pmauduit
Copy link
Copy Markdown
Member

superseded by #190 ?

@groldan
Copy link
Copy Markdown
Member

groldan commented Mar 27, 2025

Closing as superseded by #190

@groldan groldan closed this Mar 27, 2025
@f-necas f-necas deleted the spring-boot-3 branch June 11, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants