Skip to content

ISSUE-175 - Change the pictogram of the cadastrapp plugin#204

Open
LPoin wants to merge 2 commits intogeorchestra:masterfrom
jdev-org:issue-175
Open

ISSUE-175 - Change the pictogram of the cadastrapp plugin#204
LPoin wants to merge 2 commits intogeorchestra:masterfrom
jdev-org:issue-175

Conversation

@LPoin
Copy link
Copy Markdown
Contributor

@LPoin LPoin commented Dec 20, 2024

Modify Cadastrapp icon with new created by Agathe Adam.

@pierrejego pierrejego self-requested a review December 20, 2024 09:18
@pierrejego pierrejego self-assigned this Dec 20, 2024
@pierrejego pierrejego added this to the v2.2.2 milestone Dec 20, 2024
@LPoin LPoin changed the title ISSUE-175 - Change the pictogramm of the cadastrapp plugin ISSUE-175 - Change the pictogram of the cadastrapp plugin Dec 20, 2024
@landryb
Copy link
Copy Markdown
Member

landryb commented Dec 20, 2024

i think something is missing in the webpack config, because building the extension, the dist/Cadastrapp.zip archive doesn't contain the svg file. Maybe look at how it's handled for translations in https://github.com/georchestra/mapstore2-cadastrapp/blob/master/build/extension/prod-webpack.config.js#L13 ?

@pierrejego pierrejego marked this pull request as draft December 20, 2024 09:54
@pierrejego
Copy link
Copy Markdown
Member

Not tested in integration for the moment, only in dev

@LPoin
Copy link
Copy Markdown
Contributor Author

LPoin commented Dec 27, 2024

Tested in integration.
Mapstore 2023.02
Node 16.20.2

@pierrejego pierrejego marked this pull request as ready for review January 13, 2025 13:53
@pierrejego
Copy link
Copy Markdown
Member

When I upload new plugin in mapstore administration, extension Icon is not the good one. I think there is another link to change.

image

Conflict need to be resolved to merge

id="svg5"
inkscape:version="1.1 (c68e22c387, 2021-05-23)"
sodipodi:docname="interface__cadastrApp.svg"
inkscape:export-filename="C:\Users\Agathe\Desktop\Cadastrapp\Refonte_interface\Cadastrapp__interfaceSearchProp.png"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as other PR, drop unrequired personal informations ? :)

@landryb
Copy link
Copy Markdown
Member

landryb commented Feb 28, 2025

it seems this issue is stalled, without a proper resolution.. what can be done about it, besides waiting for potential feedback from geosolutions ?

@landryb
Copy link
Copy Markdown
Member

landryb commented Mar 3, 2025

the good thing is that the PR as-is at least allows to have the new icon in the sidebar, which is what end-users will see. not having the right icon in the context creation page is still an open issue, but less important.

i've rebased this PR on top of master, locally reverted the css override for .cadastrappIcon in js/extension/cadastrapp.css (because it just renders the icon greyed out/faded in the sidebar), and dropped the addition of the svg file since it's inlined in js/extension/plugins/cadastrapp/toolbar/cadastrapIcon.js.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants