-
Notifications
You must be signed in to change notification settings - Fork 26
Fix .env.local
additions in .gitignore
#21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
After reviewing the |
Thanks for the fix @evadecker! This PR merged in 1af1b7f |
@thomasballinger it looks like the last commit in my PR was left out of the merged version. I had to change some logic because inline comments aren't valid in .gitignore, and I was concerned splitting on Also added other test cases |
Oops, thanks. I'll fix that up and fix the script that pulls things into the other repo. |
@thomasballinger Doing some PR cleanup for myself. It looks like all these changes made it in, can this be closed? |
Discussed in Discord here.
This PR updates the
changesToGitIgnore()
function to more robustly check for.env.local
(and related variants), accounting for/r
on Windows or extra whitespace which previously led to false positives.New test cases were added to verify the updated conditions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.