Add type hints for settings module#3267
Merged
Merged
Conversation
avaris
reviewed
Jan 12, 2024
Types make it easier to understand the code and improve autocompletion in IDEs.
bjoernricks
force-pushed
the
setting-types
branch
from
39e8f9f to
f69e2cc
Compare
avaris
approved these changes
Jan 17, 2024
Contributor
Author
|
@avaris could you approve the workflow to be run. I guess that's missing for merging the PR. |
justinmayer
approved these changes
Jan 17, 2024
justinmayer
left a comment
justinmayer
left a comment
Member
There was a problem hiding this comment.
Many thanks to @bjoernricks for the enhancement and to @avaris for reviewing ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types make it easier to understand the code and improve autocompletion in IDEs.
Pull Request Checklist
While reading pelican's code I just added some type hints. If accepted I can upload more PRs for additional type hint.