Skip to content

feat: Add ability to manually submit release repo/commits #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

trevorkwhite
Copy link

This PR adds support for a "manual" commit range that is already supported by the CLI, but not by the action.

Since we squash and merge and have a unique setup, it's necessary to manually specify commits. This PR allows that by adding a commit_range option in addition to a manual enum on the set-commits option.

While it isn't perfect, I used a comma separated list to capture repo, current commit, previous commit. Open to doing this a cleaner way, but I didn't want to add 3 options. Perhaps it would be better to explicitly tag each of these.

PR is early, wanted to see whether this was something ya'll were open to adding.

@andreiborza andreiborza linked an issue Jun 24, 2025 that may be closed by this pull request
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trevorkwhite, thank you for contributing this. I created #287 to track this and proposed an alternative api. We should definitely support this!

action.yml Outdated
@@ -76,7 +76,12 @@ inputs:
set_commits:
description: |-
Specify whether to set commits for the release.
One of: "auto", "skip"
One of: "auto", "skip", "manual"
Copy link
Member

@andreiborza andreiborza Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of manual we could just supply a commit or a commit-range in the same format as sentry cli has it documented: https://docs.sentry.io/cli/releases/#commit-integration

No need to parse/split it and no need for extra args.

What do you think about that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I'll go ahead and make those changes to update this PR

@trevorkwhite
Copy link
Author

@andreiborza took a stab at updating the api per our conversation. I'm not super-duper familiar with node, so if the map is a crappy option, I won't take offense. Take a peek, let me know what you think, can go from there. Used regex to match the repo/commit syntax (including previous commit)

@trevorkwhite trevorkwhite changed the title feat: Add "manual" option for set-commits with commit_range feat: Add ability to manually submit release repo/commits Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting manual commits
2 participants