Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

feat(sdk): Describe trace contexts #407

Merged
merged 4 commits into from
Aug 23, 2021
Merged

feat(sdk): Describe trace contexts #407

merged 4 commits into from
Aug 23, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 20, 2021

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG
✅ Preview: https://develop-git-feat-trace-context.sentry.dev

@@ -203,7 +203,9 @@ export default () => {
<SidebarLink to="/sdk/store/">Store Endpoint</SidebarLink>
<SidebarLink to="/sdk/envelopes/">Envelopes</SidebarLink>
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink>
<SidebarLink to="/sdk/performance/">Performance</SidebarLink>
<SidebarLink to="/sdk/performance/" title="Performance">
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have the URL path /sdk/trace-context/ instead of nesting under /sdk/performance/trace-context/? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.

@@ -0,0 +1,228 @@
---
title: "Trace Contexts (Experimental)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trace state works for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants