-
-
Notifications
You must be signed in to change notification settings - Fork 223
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/FVfVuKuy3XWE9KgZ5LFZxDkYt8FG |
@@ -203,7 +203,9 @@ export default () => { | |||
<SidebarLink to="/sdk/store/">Store Endpoint</SidebarLink> | |||
<SidebarLink to="/sdk/envelopes/">Envelopes</SidebarLink> | |||
<SidebarLink to="/sdk/rate-limiting/">Rate Limiting</SidebarLink> | |||
<SidebarLink to="/sdk/performance/">Performance</SidebarLink> | |||
<SidebarLink to="/sdk/performance/" title="Performance"> | |||
<SidebarLink to="/sdk/trace-context/">Trace Contexts</SidebarLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to have the URL path /sdk/trace-context/
instead of nesting under /sdk/performance/trace-context/
? The navigation is not working as expected, once you click the link the new page Trace Contexts has no corresponding item in the sidebar visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't care much about the URL and didn't want to create folders, to be honest. We can move it if you like.
@@ -0,0 +1,228 @@ | |||
--- | |||
title: "Trace Contexts (Experimental)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is very unfortunate because SDKs already have a "Trace Context", an object that is sent in events (both errors and transactions) as event.contexts.trace
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for @RaduW -- suggestions on how we name the new trace context, instead? How about "trace state" borrowing from W3C?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trace state works for me
Rendered: https://develop-git-feat-trace-context.sentry.dev/sdk/trace-context/