This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Add client report item type to envelopes spec #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/develop/GJkZmGBf2zNBdKyQQFH5Xo7JAkiC |
mattjohnsonpint
commented
Mar 28, 2022
mattjohnsonpint
commented
Mar 28, 2022
philipphofmann
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Apart from the open question, multiple client reports be sent in a single envelope? LGTM. Thanks for helping to improve our docs, @mattjohnsonpint 👏
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Envelopes Data Model lists each possible envelope item type. Client Reports was documented on its own page, but was missing from this list.