This repository was archived by the owner on Aug 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add specification for UI event transactions with Gherkin syntax.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marandaneto
reviewed
Nov 17, 2022
marandaneto
reviewed
Nov 17, 2022
marandaneto
reviewed
Nov 17, 2022
marandaneto
reviewed
Nov 17, 2022
marandaneto
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
romtsn
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have a boolean option in SentryOptions (enableUserInteractionTracing), should we mentioned it here?
Co-authored-by: Roman Zavarnitsyn <[email protected]>
marandaneto
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @philipphofmann and once more, thank you for doing this.
romtsn
reviewed
Nov 18, 2022
romtsn
reviewed
Nov 18, 2022
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
romtsn
reviewed
Nov 18, 2022
romtsn
reviewed
Nov 18, 2022
romtsn
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor fixes + still missing enableUserInteractionTracing
option. Otherwise, LGTM 👍 thanks for doing that
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: Roman Zavarnitsyn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specification for UI event transactions with Gherkin syntax.
Fixes GH-647