feat(change_stream): MultiStream impl of ChangeStream - #643
Draft
matt-codecov wants to merge 1 commit into
Draft
matt-codecov wants to merge 1 commit into
matt-codecov wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 90.68% 90.71% +0.03%
==========================================
Files 115 115
Lines 22447 22522 +75
==========================================
+ Hits 20356 20431 +75
Misses 2091 2091
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matt-codecov
commented
Sep 21, 2026
Comment on lines
+46
to
+62
| fn write(&self, id: &ObjectId, size: u64, expires_at: Option<Timestamp>) { | ||
| for stream in self.streams.iter() { | ||
| stream.write(id, size, expires_at); | ||
| } | ||
| } | ||
|
|
||
| fn update(&self, id: &ObjectId, expires_at: Option<Timestamp>) { | ||
| for stream in self.streams.iter() { | ||
| stream.update(id, expires_at); | ||
| } | ||
| } | ||
|
|
||
| fn delete(&self, id: &ObjectId) { | ||
| for stream in self.streams.iter() { | ||
| stream.delete(id); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
these aren't async trait methods but we might internally want to spawn them concurrently in case the underlying streams become sync by blocking on a long operation instead of returning optimistically
Collaborator
There was a problem hiding this comment.
WIth that being said, therefore every operation on ChangeStream should be blocking? Or am I misunderstanding this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not currently used. demo of how
ChangeStreamFactorycan be made to work with multipleChangeStreamimpls for both storage cogs and custom garbage collection