Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Remove GitVersionTask #90

Merged
merged 1 commit into from
Jan 5, 2016
Merged

Remove GitVersionTask #90

merged 1 commit into from
Jan 5, 2016

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jan 5, 2016

This is currently incompatible with Mono. Supposed to be fixed in 4.0.0 but there's not yet a release available.

GitTools/GitVersion#264

This is currently incompatible with Mono. Supposed to be fixed in 4.0.0 but there's not yet a release available.
@dcramer
Copy link
Member Author

dcramer commented Jan 5, 2016

Unless anyone has a good reason why we need this right now I'm going to kill it since its effectively a blocker for cross platform support

dcramer added a commit that referenced this pull request Jan 5, 2016
@dcramer dcramer merged commit 6629433 into master Jan 5, 2016
@dcramer dcramer deleted the remove-gitversiontask branch January 5, 2016 21:43
@asbjornu
Copy link
Contributor

asbjornu commented Jan 6, 2016

I'd appreciate time to comment before something like this is merged. GitVersionTask is used to version the project, both at the assembly level and for the published NuGet package. Without it, releasing both unstable and stable builds of SharpRaven becomes a hell of a lot harder.

A feature branch targeting Mono would be OK, but ignoring the "develop" branch and merging this into master directly is not how I would prefer to have it handled, to put it mildly.

The way I see it, easy versioning and release management is a lot more important than Mono support at the moment. I understand the wish to have a working Travis build, but we do have a TeamCity build that works so I don't understand the desperate need to rush it.

Please revert this.

@dcramer
Copy link
Member Author

dcramer commented Jan 6, 2016

The library fully works under Mono with this change.

@asbjornu
Copy link
Contributor

asbjornu commented Jan 6, 2016

I appreciate that, but respectfully think that having simple version and release management is more important than Mono support. That is; Mono support can wait until GitVersionTask 4.0 is released. In my humble opinion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants