ref(server): Remove legacy id fallback #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still incomplete and will result in wrong normalization. The current |
untitaker
approved these changes
Oct 7, 2020
RaduW
approved these changes
Oct 9, 2020
jan-auer
added a commit
that referenced
this pull request
Oct 9, 2020
* master: ref(server): Remove legacy id fallback (#800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since project states are cached by project keys, we no longer need the lookup from project key to project id for the legacy store endpoint. Instead, Relay can query for the key's project state directly and then use that for normalization.
Project IDs are now optional on both the project state and in
RequestMeta. Event normalization then writes the project ID into the Envelope's DSN and into the event payload, after obtaining it from the project config endpoint.Since proxy and static Relays do not obtain project configuration, they no longer support the legacy API endpoint.