ci: Add an action to release the library #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
ci/release-library
branch
from
31ce4dd to
24d2ea4
Compare
BYK
reviewed
Jan 25, 2021
| with: | ||
| version: ${{ github.event.inputs.version }} | ||
| force: ${{ github.event.inputs.force }} | ||
| path: py |
There was a problem hiding this comment.
Why not parametrize the main release action instead?
There was a problem hiding this comment.
I feared that this would be too error prone. One is CalVer, the other one requires a version. One is released on schedule, the other only ever manually.
They do look quite similar, though.
There was a problem hiding this comment.
Hmm, we can set CalVer automatically and disable if path exists but I'm not sure if the complexity is worth it at this point. Maybe we can have the duplication until we have more then?
There was a problem hiding this comment.
Sounds good to me, let's go ahead with the current patch then. Thanks!
BYK
approved these changes
Jan 25, 2021
RaduW
approved these changes
Jan 25, 2021
jan-auer
added a commit
that referenced
this pull request
Jan 27, 2021
* master: fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913) release: 21.1.0 ci: Fix clippy command invocation ci: Run clippy via the cargo action feat(server): Ingest and normalize sample rates (#910)
jan-auer
added a commit
that referenced
this pull request
Jan 28, 2021
* master: fix(server): Log when recovering from network outages (#918) feat: Add a .no-cache option to event sending (#911) fix: Build proper 64-bit Linux wheel release: 0.8.2 chore: Switch to manylinux2010 (#917) meta(py): Changelog for 0.8.2 ci: Add an action to release the library (#916) ref: Remove Compatibility mode for Session Aggregates (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another action similar to the main Release action that publishes the Python
library. It runs craft in the
pysubfolder.#skip-changelog