Skip to content

Added reason to mocked HTTPResponse #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcramer merged 1 commit into from
Dec 15, 2016
Merged

Added reason to mocked HTTPResponse #132

dcramer merged 1 commit into from
Dec 15, 2016

Conversation

@whs
Copy link
Contributor

@whs whs commented Dec 15, 2016

See #130

The field reason is missing from the mocked request. It is usually set to HTTP status code's readable name (eg. "OK" "Not Found")

This make some libraries, like requests_toolbelt dumping unhappy.

@whs whs mentioned this pull request Dec 15, 2016
Closed
@dcramer
Copy link
Member

dcramer commented Dec 15, 2016

Thanks!

@dcramer dcramer merged commit fa312f5 into getsentry:master Dec 15, 2016
@jaap3 jaap3 mentioned this pull request Mar 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whs @dcramer