Added Py39 support #327
Merged
Added Py39 support #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 3 3
Lines 1184 1184
=======================================
Hits 1136 1136
Misses 48 48
Continue to review full report at Codecov.
|
mgorny
reviewed
Jun 11, 2020
| @@ -399,7 +400,10 @@ def run(): | |||
| responses.add(responses.GET, url, body="test", status=418) | |||
| resp = requests.get(url) | |||
| assert resp.status_code == 418 | |||
| assert resp.reason is None | |||
There was a problem hiding this comment.
I'm not sure if the code is 'arbitrary' now, though. I suppose the purpose might be to use a code that isn't supported.
There was a problem hiding this comment.
Good point 👍
I changed the status code to 419
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 release is on October 5, 2020.