Skip to content

Add requirement for urllib3 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add requirement for urllib3 #338

merged 1 commit into from
Aug 11, 2020

Conversation

markstory
Copy link
Member

This upgrades urllib3 to a version that provides the cookie interfaces that this library depends on. Earlier versions lack a get_all() method on HTTPHeaderDict

Refs #292

This upgrades urllib3 to a version that provides the cookie interfaces
that this library depends on. Earlier versions lack a get_all() method
on HTTPHeaderDict

Refs #292
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files           3        3           
  Lines        1184     1184           
=======================================
  Hits         1136     1136           
  Misses         48       48           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96c494...881ad77. Read the comment docs.

@markstory markstory merged commit 16bfa09 into master Aug 11, 2020
@markstory markstory deleted the urllib-dep branch August 11, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants