Attempting to upgrade self hosted 23.12.0 to 24.8.0

[jamincollins]

Self-Hosted Version

23.12.0

CPU Architecture

x86_64

Docker Version

29.2.1

Docker Compose Version

5.0.2

Machine Specification

• My system meets the minimum system requirements of Sentry

Installation Type

Upgrade from 23.12.0

Steps to Reproduce

1. docker-compose stop
2. update sentry/sentry.conf.py for memcache changes
3. git fetch
4. git checkout 24.8.0
5. ./install.sh

Expected Result

Upgrade completes without error.

Actual Result

Digest: sha256:b83d9c2690c7f34ed465ae2d8ac9ae7d91ba9e0d9c536384dd28aca0b4c1c0fc
Status: Downloaded newer image for getsentry/sentry-cli:latest
docker.io/getsentry/sentry-cli:latest

▶ Checking for latest commit ... 

▶ Checking minimum requirements ...
Found Docker version 29.2.1
Found Docker Compose version 5.0.2

▶ Upgrading Clickhouse ...
service "zookeeper" has neither an image nor a build context specified: invalid compose project
Error in install/upgrade-clickhouse.sh:15.
'$dc up -d clickhouse' exited with status 1
-> ./install.sh:main:25
--> install/upgrade-clickhouse.sh:source:15

Envelope from file sentry-envelope-d941fcc71fe240bd3650e91099bc757d dispatched
Cleaning up...

Event ID

No response

[aldy505]

Okay, I'm just gonna focus on this issue first. During git checkout 24.8.0, do you have any docker-compose.overrides.yml or a custom docker-compose.yml? Since we moved to KRaft on that tag. The PR is here: #3263

[jamincollins]

$ cat docker-compose.override.yml 
services:
  zookeeper:
    ulimits:
      nofile:
        soft: 2048
        hard: 2048
  kafka:
    ulimits:
      nofile:
        soft: 4096
        hard: 4096
  web:
    ulimits:
      nofile:
        soft: 4096
        hard: 4096

[aldy505]

Ah yes, you need to remove zookeeper block from your override.