-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Reference to realpath in install script breaks macOS compatibility #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@misswyy I'm able to work around this issue with |
Hi @10xjs, thanks for the report! We expect folks to use this repo on Linux machines so that's what we test this on. That said we like keeping it compatible with MacOS so I'll see what we can do here. |
Blerp. Workaround is |
Same issue, fixed by running but then hit another error:
Fixed this error by running Docker process first. It's odd that parts of the build are outside Docker, isn't the point of Docker to have a cross-platform development environment?
|
Not a bad idea, though this would be a pretty significant rewrite. Reticketed as #999.
I guess we could add an explicit check for whether Docker is running? Or at least something to the docs to say "Make sure Docker is running"? |
Version Information
Version:
2.3.1
Steps to Reproduce
./install.sh
on macOS (11.2.3
)Expected Result
Install script runs successfully.
Actual Result
Install script immediately fails.
Logs
What you saw along the way, e.g.:
./install/_lib.sh: line 15: realpath: command not found
The text was updated successfully, but these errors were encountered: