Skip to content

Reference to realpath in install script breaks macOS compatibility #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10xjs opened this issue Apr 29, 2021 · 9 comments · Fixed by #1539
Closed

Reference to realpath in install script breaks macOS compatibility #941

10xjs opened this issue Apr 29, 2021 · 9 comments · Fixed by #1539

Comments

@10xjs
Copy link

10xjs commented Apr 29, 2021

Version Information

Version: 2.3.1

Steps to Reproduce

  1. run ./install.sh on macOS (11.2.3)

Expected Result

Install script runs successfully.

Actual Result

Install script immediately fails.

Logs

What you saw along the way, e.g.:

  • ./install/_lib.sh: line 15: realpath: command not found
@10xjs
Copy link
Author

10xjs commented Apr 29, 2021

This has already been (unsuccessfully) reported in #932 and #933.

@10xjs
Copy link
Author

10xjs commented Apr 29, 2021

@misswyy I'm able to work around this issue with git checkout 2.3.1 if you are still looking for a solution.

@BYK
Copy link
Member

BYK commented Apr 30, 2021

Hi @10xjs, thanks for the report! We expect folks to use this repo on Linux machines so that's what we test this on. That said we like keeping it compatible with MacOS so I'll see what we can do here.

@chadwhitacre
Copy link
Member

Blerp. Workaround is brew install coreutils until we get a fix in. Sorry!

@kmturley
Copy link

kmturley commented Jun 16, 2021

Same issue, fixed by running brew install coreutils

but then hit another error:

▶ Parsing command line ...

▶ Setting up error handling ...

▶ Checking minimum requirements ...
An error occurred, caught SIGERR on line 12

Fixed this error by running Docker process first.

It's odd that parts of the build are outside Docker, isn't the point of Docker to have a cross-platform development environment?

docker-compose up can spin up multiple containers, running installation scripts inside the containers themselves?

@chadwhitacre
Copy link
Member

running installation scripts inside the containers themselves

Not a bad idea, though this would be a pretty significant rewrite. Reticketed as #999.

Fixed this error by running Docker process first.

I guess we could add an explicit check for whether Docker is running? Or at least something to the docs to say "Make sure Docker is running"?

@tingfeima

This comment has been minimized.

@chadwhitacre

This comment has been minimized.

@kmturley

This comment was marked as off-topic.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants