-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Cleanup .env{,.custom} handling #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good to me! |
I tested this locally on a clean machine (running
|
5e4ab38
to
2a5b55f
Compare
What's up with CI? 🤔
This isn't a familiar CI flake. Is it authentic? |
Yup, and it's downstream of @aminvakil's result:
|
6b59449
to
12dcb88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Its a shame there isn't a shell linter that reports macOS/linux incompatibilities :/
Oooooh ... good idea! :) |
Fixes #941, also addresses the suggestion for a README tweak at the very bottom of #1491 (comment).
Look good to you, @aminvakil @glensc @Daniel15?