Skip to content

Fix #1079 - bug in reset.sh #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fix #1079 - bug in reset.sh #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reset.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,4 @@ if [ -n "$version" ]; then
fi

# Install.
exec ./install.sh
./install.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the original intent of using exec?

This piece of logic might be usable instead of source "$(dirname $0)/_min-requirements.sh":
https://github.com/getsentry/sentry/blob/6776229fbde4ca8cd52884d369a1b498a43dc6b4/scripts/do.sh#L5-L10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a strong reason to use exec originally. I did it that way because conceptually we are done with the one script so figured we'd hand off to the next, didn't think through the nuances.

I've started trying to whittle down a better repro in order to understand better what's going on and what the best solution is. That's turning out to take more time than I'd like, though. This reset.sh script is hacky and mostly for me. The real bug I want to focus on is #1133.

You okay to merge as-is?