chore: support for m1 mac #1487
Conversation
|
This pull request was tentatively created to run this repository on m1 mac. With this branch, If you have any questions, please feel free to contact me. I hope Clickhouse supports m1 mac... |
| @@ -1,5 +1,5 @@ | |||
| <yandex> | |||
| <max_server_memory_usage_to_ram_ratio from_env="MAX_MEMORY_USAGE_RATIO" /> | |||
| <max_server_memory_usage_to_ram_ratio>0.3</max_server_memory_usage_to_ram_ratio> | |||
There was a problem hiding this comment.
Why should we use an exact value instead of using envs?
There was a problem hiding this comment.
@aminvakil
I don't know the exact reason, but without this change, Clickhouse would be unhealthy.
reference
| @@ -186,7 +186,7 @@ services: | |||
| test: ["CMD-SHELL", "nc -z localhost 9092"] | |||
| clickhouse: | |||
| <<: *restart_policy | |||
| image: "yandex/clickhouse-server:20.3.9.70" | |||
| image: "altinity/clickhouse-server:21.12.3.32.altinitydev.arm" | |||
There was a problem hiding this comment.
Does this work in x64 architectures?
There was a problem hiding this comment.
@aminvakil
I'm sorry, but I don't know because I only checked this branch with m1 mac.
|
Thanks for this, but we clearly cannot change this repository and break every other user not using an arm CPU :) Please make a PR working for both x64 and arm architectures and we can discuss on it. |
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.