feat: allow upgrade tests - #4288
Conversation
Changelog Preview📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 404e19e. Configure here.
| image="${image_urls[$i]}" | ||
| image_var=$(echo "${project}_IMAGE" | tr '[:lower:]' '[:upper:]') | ||
| echo "${image_var}=${image}" >> ${{ github.action_path }}/.env | ||
| done |
There was a problem hiding this comment.
Trailing newline causes empty element in readarray
Medium Severity
When callers pass multiline inputs using YAML | block scalar syntax (the standard way), the value includes a trailing newline. The <<< herestring adds another newline, so readarray -t produces an extra empty string element in both project_names and image_urls. The length check passes (both arrays have the same extra element), but the loop then writes a garbage _IMAGE= entry to the .env file. Using < <(printf '%s' "$PROJECT_NAME") instead of <<<"$PROJECT_NAME" would avoid this.
Reviewed by Cursor Bugbot for commit 404e19e. Configure here.
2 participants
To be able to run upgrade tests against self-hosted, this is most useful to test database migrations