Skip to content

Increase proxy_read_timeout to 90s - #4368

Merged
aldy505 merged 2 commits into
getsentry:masterfrom
aminvakil:nginx_proxy_read_timeout
Jun 10, 2026
Merged

Increase proxy_read_timeout to 90s#4368
aldy505 merged 2 commits into
getsentry:masterfrom
aminvakil:nginx_proxy_read_timeout

Conversation

@aminvakil

Copy link
Copy Markdown
Collaborator

On a large self-hosted instance, 30 seconds is too low for querying, also sentry keeps on doing the work (whatever it is) and nginx just drops the connection.

It's better to match this to sentry timeouts, this should also consider whether this is ok for slow API requests or not, as current change affects both.

Maybe we should separate these two? I'm going to draft this until I think about this more.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505

aldy505 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Why this is a draft?

@aldy505 aldy505 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's 120s, I would accept it as well

@aminvakil

Copy link
Copy Markdown
Collaborator Author

Why this is a draft?

I wanted to think about this more and I also wanted to check sentry timeouts as well, if sentry panel uses 180s timeouts for example.

I just wanted to reach the correct number for making it ready for review. Give me 24 hours :)

@aldy505

aldy505 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Why this is a draft?

I wanted to think about this more and I also wanted to check sentry timeouts as well, if sentry panel uses 180s timeouts for example.

I just wanted to reach the correct number for making it ready for review. Give me 24 hours :)

Fair enough 👌🏻

@aminvakil
aminvakil force-pushed the nginx_proxy_read_timeout branch from 98acb61 to 7287c72 Compare June 9, 2026 14:37
@aminvakil

Copy link
Copy Markdown
Collaborator Author

Regarding sentry timeouts:
https://github.com/getsentry/sentry/blob/master/src/sentry/services/http.py

There isn't a timeout option getting passed to granian AFAICS, it's good to get merged as it is.

@aminvakil
aminvakil marked this pull request as ready for review June 9, 2026 15:32
Comment thread nginx.conf
@aldy505
aldy505 merged commit ba82c80 into getsentry:master Jun 10, 2026
13 checks passed
@aminvakil
aminvakil deleted the nginx_proxy_read_timeout branch June 11, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants