Increase proxy_read_timeout to 90s - #4368
Conversation
|
Why this is a draft? |
aldy505
left a comment
There was a problem hiding this comment.
If it's 120s, I would accept it as well
I wanted to think about this more and I also wanted to check sentry timeouts as well, if sentry panel uses 180s timeouts for example. I just wanted to reach the correct number for making it ready for review. Give me 24 hours :) |
Fair enough 👌🏻 |
98acb61 to
7287c72
Compare
|
Regarding sentry timeouts: There isn't a timeout option getting passed to |
On a large self-hosted instance, 30 seconds is too low for querying, also sentry keeps on doing the work (whatever it is) and
nginxjust drops the connection.It's better to match this to sentry timeouts, this should also consider whether this is ok for slow API requests or not, as current change affects both.
Maybe we should separate these two? I'm going to draft this until I think about this more.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.