Skip to content

Increase web healthcheck start_period - #4387

Merged
aldy505 merged 1 commit into
getsentry:masterfrom
aminvakil:web_healthcheck
Jun 29, 2026
Merged

Increase web healthcheck start_period#4387
aldy505 merged 1 commit into
getsentry:masterfrom
aminvakil:web_healthcheck

Conversation

@aminvakil

Copy link
Copy Markdown
Collaborator

Increase web service start_period healthcheck to 5 minutes.

This is an attempt to fix integration test flaky integration test and failure after 2 minutes.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil

Copy link
Copy Markdown
Collaborator Author

First attempt passed.

@aminvakil

Copy link
Copy Markdown
Collaborator Author

Second attempt passed.

@aminvakil aminvakil closed this Jun 25, 2026
@aminvakil aminvakil reopened this Jun 25, 2026
@aminvakil aminvakil closed this Jun 25, 2026
@aminvakil aminvakil reopened this Jun 25, 2026
@aminvakil aminvakil closed this Jun 25, 2026
@aminvakil aminvakil reopened this Jun 25, 2026
@aminvakil

Copy link
Copy Markdown
Collaborator Author

It didn't fail on 5 attempts.

@aldy505

aldy505 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

I'm going to try a second option, which just got merged yesterday: getsentry/sentry#118444

@aminvakil

Copy link
Copy Markdown
Collaborator Author

I'm going to try a second option, which just got merged yesterday: getsentry/sentry#118444

AFAICS that PR adds a flag to investigate further and does not fix the actual problem yet.

@aldy505

aldy505 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

I'm going to try a second option, which just got merged yesterday: getsentry/sentry#118444

AFAICS that PR adds a flag to investigate further and does not fix the actual problem yet.

Yes, I'll text you on Discord

@aldy505

aldy505 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Hmm, the latest scheduled runs also failed on the web container: http://github.com/getsentry/self-hosted/actions/runs/28395141165/job/84131871385

@aldy505
aldy505 merged commit 9d7521d into getsentry:master Jun 29, 2026
43 checks passed
@aminvakil
aminvakil deleted the web_healthcheck branch June 30, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants