feat: Mark all files subcommands as deprecated.
#2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
swatinem/deprecate-release-files
branch
from
425455b to
dbdb6a3
Compare
szokeasaurusrex
changed the title
files subcommands as deprecated.files subcommands as deprecated.
src/commands/files/mod.rs
Outdated
Comment on lines
47
to
48
| println!("{}", style("⚠ DEPRECATION NOTICE: This functionality will be removed in a future version of `sentry-cli`. \ | ||
| Use the `sourcemaps` command instead.").yellow()); |
There was a problem hiding this comment.
We should probably use eprintln! for this:
Suggested change
| println!("{}", style("⚠ DEPRECATION NOTICE: This functionality will be removed in a future version of `sentry-cli`. \ | |
| Use the `sourcemaps` command instead.").yellow()); | |
| eprintln!("{}", style("⚠ DEPRECATION NOTICE: This functionality will be removed in a future version of `sentry-cli`. \ | |
| Use the `sourcemaps` command instead.").yellow()); |
We will also need to update this docs section (including subsections) to reflect this change; that page makes it seem like the sourcemaps commands are a "special case" of the files commands
There was a problem hiding this comment.
Done.
Thanks for the reminder: getsentry/sentry-docs#13767
The commands are now hidden from help output (making them less likely to be discovered and used), and they are marked with a deprecation notice. When invoking the commands, a deprecation notice will be printed as well. Also the previously deprecated `sourcemaps explain` command (which was explained by an in-app sourcemaps debugger) which already prints a deprecation notice is also being marked as hidden to be less discoverabe.
Swatinem
force-pushed
the
swatinem/deprecate-release-files
branch
from
dbdb6a3 to
1c4594c
Compare
szokeasaurusrex
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands are now hidden from help output (making them less likely to be discovered and used), and they are marked with a deprecation notice.
When invoking the commands, a deprecation notice will be printed as well.
Also the previously deprecated
sourcemaps explaincommand (which was replaced by an in-app sourcemaps debugger) which already prints a deprecation notice is also being marked as hidden to be less discoverable.Ref #2513