Skip to content

Conversation

@brustolin
Copy link
Contributor

@brustolin brustolin commented Feb 1, 2023

SentryTracer is the core of performance, and it gets bigger and bigger with each new feature, therefore is getting harder to understand it.

This is the first step to reduce it. The goal in the future is to extract more behavior from it and use DI as replacement.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.12 ms 1241.88 ms 7.76 ms
Size 20.76 KiB 420.41 KiB 399.65 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9faf217 1268.86 ms 1274.82 ms 5.96 ms
4977fbc 1231.55 ms 1239.80 ms 8.25 ms
156e771 1228.06 ms 1242.64 ms 14.58 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
302ee8b 1194.02 ms 1223.34 ms 29.32 ms
15b8c61 1223.16 ms 1244.83 ms 21.67 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms
1bd0055 1207.57 ms 1223.10 ms 15.53 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
dc0db9e 1222.10 ms 1240.90 ms 18.80 ms

App size

Revision Plain With Sentry Diff
9faf217 20.76 KiB 419.70 KiB 398.94 KiB
4977fbc 20.76 KiB 419.86 KiB 399.10 KiB
156e771 20.76 KiB 419.70 KiB 398.94 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
302ee8b 20.76 KiB 419.62 KiB 398.87 KiB
15b8c61 20.76 KiB 419.67 KiB 398.91 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB
1bd0055 20.76 KiB 420.22 KiB 399.46 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
dc0db9e 20.76 KiB 419.62 KiB 398.86 KiB

Previous results on branch: ref/sentrytracer

Startup times

Revision Plain With Sentry Diff
285cf09 1232.33 ms 1238.46 ms 6.13 ms
32ba1e7 1233.82 ms 1255.69 ms 21.88 ms

App size

Revision Plain With Sentry Diff
285cf09 20.76 KiB 420.40 KiB 399.64 KiB
32ba1e7 20.76 KiB 420.40 KiB 399.64 KiB

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #2675 (05a1472) into main (8674267) will increase coverage by 0.09%.
The diff coverage is 92.10%.

❗ Current head 05a1472 differs from pull request most recent head 0543c2f. Consider uploading reports for the commit 0543c2f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
+ Coverage   80.51%   80.60%   +0.09%     
==========================================
  Files         247      247              
  Lines       22962    22862     -100     
  Branches    10154    10127      -27     
==========================================
- Hits        18487    18428      -59     
+ Misses       4008     3858     -150     
- Partials      467      576     +109     
Impacted Files Coverage Δ
Sources/Sentry/SentryTracer.m 97.04% <90.32%> (+1.57%) ⬆️
Sources/Sentry/SentrySpan.m 97.98% <100.00%> (+12.46%) ⬆️
Sources/Sentry/SentryTime.mm 68.00% <0.00%> (-20.00%) ⬇️
Sources/Sentry/SentryRequestOperation.m 67.56% <0.00%> (-10.82%) ⬇️
...ryCrash/Recording/Tools/SentryCrashDynamicLinker.c 79.77% <0.00%> (-0.08%) ⬇️
Sources/Sentry/SentryDevice.mm 53.09% <0.00%> (ø)
Sources/Sentry/SentryProfiler.mm 79.48% <0.00%> (ø)
Sources/Sentry/SentryScreenshot.m 73.52% <0.00%> (ø)
Sources/Sentry/SentryCrashWrapper.m 84.31% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8674267...0543c2f. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the refactoring @brustolin.

@brustolin brustolin merged commit ddc9b9a into main Feb 3, 2023
@brustolin brustolin deleted the ref/sentrytracer branch February 3, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants