-
-
Notifications
You must be signed in to change notification settings - Fork 372
ref: Make SentryTracer sub class of SentrySpan #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
| 4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
| 156e771 | 1228.06 ms | 1242.64 ms | 14.58 ms |
| 83d2d84 | 1211.31 ms | 1227.34 ms | 16.03 ms |
| 302ee8b | 1194.02 ms | 1223.34 ms | 29.32 ms |
| 15b8c61 | 1223.16 ms | 1244.83 ms | 21.67 ms |
| 4c00f8c | 1231.62 ms | 1237.76 ms | 6.14 ms |
| 1bd0055 | 1207.57 ms | 1223.10 ms | 15.53 ms |
| e71cf92 | 1201.69 ms | 1226.52 ms | 24.83 ms |
| dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
| 156e771 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 83d2d84 | 20.76 KiB | 419.66 KiB | 398.90 KiB |
| 302ee8b | 20.76 KiB | 419.62 KiB | 398.87 KiB |
| 15b8c61 | 20.76 KiB | 419.67 KiB | 398.91 KiB |
| 4c00f8c | 20.76 KiB | 419.62 KiB | 398.86 KiB |
| 1bd0055 | 20.76 KiB | 420.22 KiB | 399.46 KiB |
| e71cf92 | 20.76 KiB | 419.85 KiB | 399.10 KiB |
| dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
==========================================
+ Coverage 80.51% 80.60% +0.09%
==========================================
Files 247 247
Lines 22962 22862 -100
Branches 10154 10127 -27
==========================================
- Hits 18487 18428 -59
+ Misses 4008 3858 -150
- Partials 467 576 +109
Continue to review full report at Codecov.
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the refactoring @brustolin.
SentryTracer is the core of performance, and it gets bigger and bigger with each new feature, therefore is getting harder to understand it.
This is the first step to reduce it. The goal in the future is to extract more behavior from it and use DI as replacement.
#skip-changelog