fix: Multiple attachments support for feedback#6459
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6459 +/- ##
=============================================
- Coverage 85.145% 85.105% -0.041%
=============================================
Files 453 453
Lines 27689 27695 +6
Branches 12111 12118 +7
=============================================
- Hits 23576 23570 -6
- Misses 4069 4082 +13
+ Partials 44 43 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
(Closed and reopened this to retrigger workflows) |
@itaybre Apparently running workflows require manual approval |
|
Looks like you need to fix the Changelog due to the alpha release of v9 |
Right, moved the new changelog entry to |
|
@philprime I see that some CI checks are failing due to the missing |
|
I'll try to push a commit to this PR so hopefully it uses my permissions and exposes the GitHub secrets |
This reverts commit 4c86b44.
|
We probably have to reopen this PR as soon as you repo write access |
Right, I’ll re-create it once I receive the invite (still waiting for it) |
|
Superseded by #6752 |
📜 Description
Updated
SentryFeedbackto accept[Attachment]objects instead of raw[Data]arrays, enabling proper support formultiple attachments with full metadata (filename, content type, etc.).
This also introduces some breaking changes to public API:
initmethod signaturedataDictionary()method now returns attachments as[[String: Any]]with metadata instead of[Data]affecting consumers of theonSubmitSuccesscallbackThis issue originally came up in Unreal SDK while adding attachment support for user feedback:
💡 Motivation and Context
The previous implementation had several limitations:
attachmentsForEnvelope()assumed all attachments were screenshots and hardcoded filename: "screenshot.png" and contentType: "application/png"💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.