Skip to content

Enha: Exceptions not handled by user code should be unhandled: true #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denrase wants to merge 21 commits into from
Closed

Enha: Exceptions not handled by user code should be unhandled: true #1186

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5086d07
update handled behaviour in on_error_integration
denrase Dec 13, 2022
aa7da3a
updaate handled behaviour in flutter_error_integration
denrase Dec 13, 2022
4c91f0e
change behaviour in RunZonedGuardedIntegration
denrase Dec 13, 2022
e09271d
updated handled behaviour in isolate error integration
denrase Dec 13, 2022
f21a150
explicitly test mechanisms handled value
denrase Dec 13, 2022
8eecafb
add changelog entry
denrase Dec 13, 2022
cb063d5
fix typo
denrase Dec 13, 2022
5009352
always set handled to false in flutter error integration
denrase Dec 13, 2022
ed58af6
always set to handled false
denrase Dec 13, 2022
560fe83
fix replacement
denrase Dec 13, 2022
c708f7c
rename var
denrase Dec 13, 2022
2f79a4f
format
denrase Dec 13, 2022
ab25ce8
check flase non-null
denrase Dec 13, 2022
930068d
Merge branch 'v7.0.0' into enha/exceptions-not-handled-by-user-code-s…
denrase Dec 19, 2022
3b894ce
return false as fallback
denrase Dec 19, 2022
b631196
remove breadcrumbs from unhandled but not crashing events
denrase Dec 19, 2022
38d1c7f
revert breadcrumb removal for unhandledButNotCrashingMechanisms
denrase Jan 9, 2023
bf16ece
Merge branch 'main' into enha/exceptions-not-handled-by-user-code-sho…
marandaneto Jan 9, 2023
dbed0d4
remove dupe crumbs
marandaneto Jan 10, 2023
102076d
updat changelog entry
denrase Jan 10, 2023
6f8de6c
Merge branch 'v7.0.0' into enha/exceptions-not-handled-by-user-code-s…
denrase Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions dart/lib/src/sentry_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,19 +399,19 @@ class SentryClient {
}

SentryEvent _eventWithRemovedBreadcrumbsIfHandled(SentryEvent event) {
final mechanisms = (event.exceptions ?? [])
.map((e) => e.mechanism)
.whereType<Mechanism>();
final hasNoMechanism = mechanisms.isEmpty;

final hasOnlyHandledMechanism = mechanisms
.every((e) => (e.handled ?? true));

if (hasNoMechanism || hasOnlyHandledMechanism) {
return event.copyWith(breadcrumbs: []);
} else {
return event;
}
// final mechanisms = (event.exceptions ?? [])
// .map((e) => e.mechanism)
// .whereType<Mechanism>();
// final hasNoMechanism = mechanisms.isEmpty;

// final hasOnlyHandledMechanism = mechanisms
// .every((e) => (e.handled ?? true));

// if (hasNoMechanism || hasOnlyHandledMechanism) {
Copy link
Collaborator Author

@denrase denrase Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marandaneto Is this final or are you still in implementation process?

Copy link
Contributor

@marandaneto marandaneto Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just testing and found out that this has to be fixed, hence the comments.

return event.copyWith(breadcrumbs: []);
// } else {
// return event;
// }
}

Future<SentryId?> _attachClientReportsAndSend(SentryEnvelope envelope) {
Expand Down
5 changes: 5 additions & 0 deletions flutter/lib/src/integrations/load_contexts_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ class _LoadContextsIntegrationEventProcessor extends EventProcessor {
final breadcrumbsList = infos['breadcrumbs'] as List?;
if (breadcrumbsList != null && breadcrumbsList.isNotEmpty) {
final breadcrumbs = event.breadcrumbs ?? [];
if ((_options.platformChecker.platform.isIOS ||
_options.platformChecker.platform.isMacOS) &&
_options.enableScopeSync) {
breadcrumbs.clear();
}
final newBreadcrumbs =
List<Map<dynamic, dynamic>>.from(breadcrumbsList);

Expand Down