-
-
Notifications
You must be signed in to change notification settings - Fork 257
Enums use its name instead of non exhaustive switches #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
+ Coverage 88.65% 90.28% +1.63%
==========================================
Files 142 181 +39
Lines 4389 5764 +1375
==========================================
+ Hits 3891 5204 +1313
- Misses 498 560 +62
☔ View full report in Codecov by Sentry. |
ueman
reviewed
Jun 5, 2023
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
f2db4ec | 372.46 ms | 469.72 ms | 97.26 ms |
68677de | 364.41 ms | 415.61 ms | 51.20 ms |
0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
86d4841 | 286.35 ms | 372.43 ms | 86.08 ms |
dd1f7d2 | 338.54 ms | 387.10 ms | 48.56 ms |
f1314d5 | 313.89 ms | 372.10 ms | 58.21 ms |
24f71aa | 358.49 ms | 455.90 ms | 97.41 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
f96ca24 | 316.08 ms | 388.22 ms | 72.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
f2db4ec | 6.06 MiB | 7.03 MiB | 990.27 KiB |
68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
86d4841 | 6.15 MiB | 7.13 MiB | 1000.49 KiB |
dd1f7d2 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
f1314d5 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
24f71aa | 6.06 MiB | 7.03 MiB | 990.30 KiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
f96ca24 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
11fb408 | 1256.14 ms | 1283.51 ms | 27.37 ms |
a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
90db9ff | 1277.18 ms | 1283.69 ms | 6.51 ms |
c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
322aa66 | 1251.68 ms | 1275.52 ms | 23.84 ms |
6491ebd | 1231.41 ms | 1245.35 ms | 13.94 ms |
b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
d301b11 | 1260.61 ms | 1272.06 ms | 11.45 ms |
8cb6557 | 1265.14 ms | 1266.08 ms | 0.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
11fb408 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
90db9ff | 8.10 MiB | 9.08 MiB | 1004.27 KiB |
c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
322aa66 | 8.15 MiB | 9.12 MiB | 992.53 KiB |
6491ebd | 8.29 MiB | 9.36 MiB | 1.07 MiB |
b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
d301b11 | 8.10 MiB | 9.07 MiB | 1000.82 KiB |
8cb6557 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
stefanosiano
approved these changes
Jun 5, 2023
krystofwoldrich
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Enums will use its name instead of non-exhaustive switches
Since Dart 2.15 we can use the
name
if they match 1 by 1.💡 Motivation and Context
#1503 and #1504
Follow up by @abdelrahmanelmarakby thanks :)
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps