-
-
Notifications
You must be signed in to change notification settings - Fork 266
fix(web): use if (dart.library.html)
instead of if (dart.html)
#2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## temp/8.13.2 #2736 +/- ##
==============================================
Coverage ? 92.22%
==============================================
Files ? 90
Lines ? 2931
Branches ? 0
==============================================
Hits ? 2703
Misses ? 228
Partials ? 0 ☔ View full report in Codecov by Sentry. |
expect(jsOptions['defaultIntegrations'][1].toString(), | ||
contains('name: Dedupe')); | ||
}); | ||
// TODO: re-enable this test in V9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's skip this test for now since the dart:html
part of it doesn't work anymore with the newest flutter version. we are going to remove the dart:html
usages anyway in v9 so spending more time on fixing this is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except failing analyzer.
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * Use global ruby for `pod install` in min version test (#2783) * chore(deps): update Cocoa SDK to v8.46.0 (#2772) * chore: update flutter/scripts/update-cocoa.sh to 8.46.0 * Update CHANGELOG.md --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]> * Bind root screen transaction to scope (#2756) * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG * Prepare `8.14.0` changelog (#2787) * update CHANGELOG * update * Update CHANGELOG.md * Update CHANGELOG.md * release: 8.14.0 --------- Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
📜 Description
💡 Motivation and Context
Fixes #2735
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps