Skip to content

fix(web): use if (dart.library.html) instead of if (dart.html) #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 20, 2025

📜 Description

💡 Motivation and Context

Fixes #2735

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (temp/8.13.2@2b7ea90). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             temp/8.13.2    #2736   +/-   ##
==============================================
  Coverage               ?   92.22%           
==============================================
  Files                  ?       90           
  Lines                  ?     2931           
  Branches               ?        0           
==============================================
  Hits                   ?     2703           
  Misses                 ?      228           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

expect(jsOptions['defaultIntegrations'][1].toString(),
contains('name: Dedupe'));
});
// TODO: re-enable this test in V9
Copy link
Contributor Author

@buenaflor buenaflor Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's skip this test for now since the dart:html part of it doesn't work anymore with the newest flutter version. we are going to remove the dart:html usages anyway in v9 so spending more time on fixing this is not needed

@buenaflor buenaflor requested a review from denrase February 20, 2025 14:55
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except failing analyzer.

@buenaflor buenaflor merged commit 135d6e4 into temp/8.13.2 Feb 20, 2025
59 of 61 checks passed
@buenaflor buenaflor deleted the fix/dart_html_import branch February 20, 2025 15:08
buenaflor added a commit that referenced this pull request Feb 20, 2025
* update Android dependency to 7.22.0 (#2705)

* fix: navigation breadcrumb with missing to crashes native (#2720)

* release: 8.13.1

* update changelog

* fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736)

* fix

* regenerate mocks

* update CHANGELOG

* update test

* update

* fix test

* release: 8.13.2

---------

Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
buenaflor added a commit that referenced this pull request Mar 12, 2025
* update Android dependency to 7.22.0 (#2705)

* fix: navigation breadcrumb with missing to crashes native (#2720)

* release: 8.13.1

* update changelog

* fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736)

* fix

* regenerate mocks

* update CHANGELOG

* update test

* update

* fix test

* release: 8.13.2

* chore(deps): update Android SDK to v7.22.1 (#2785)

* update android dep

* update changelog

* update CHANGELOG

* release: 8.13.3

* update CHANGELOG

---------

Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
buenaflor added a commit that referenced this pull request Mar 12, 2025
* update Android dependency to 7.22.0 (#2705)

* fix: navigation breadcrumb with missing to crashes native (#2720)

* release: 8.13.1

* update changelog

* fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736)

* fix

* regenerate mocks

* update CHANGELOG

* update test

* update

* fix test

* release: 8.13.2

* Use global ruby for  `pod  install` in min version test (#2783)

* chore(deps): update Cocoa SDK to v8.46.0 (#2772)

* chore: update flutter/scripts/update-cocoa.sh to 8.46.0

* Update CHANGELOG.md

---------

Co-authored-by: GitHub <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>

* Bind root screen transaction to scope (#2756)

* chore(deps): update Android SDK to v7.22.1 (#2785)

* update android dep

* update changelog

* update CHANGELOG

* release: 8.13.3

* update CHANGELOG

* Prepare `8.14.0` changelog (#2787)

* update CHANGELOG

* update

* Update CHANGELOG.md

* Update CHANGELOG.md

* release: 8.14.0

---------

Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: Denis Andrašec <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants