-
-
Notifications
You must be signed in to change notification settings - Fork 267
Update GH actions run vars #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cb956f6
Use `env` vars instead of directly input values in run commands
denrase e6f2488
Use env in more places
denrase 3dc7afc
Merge branch 'main' into chore/update-gh-actions-run-vars
denrase aa87a3e
conditionally run dart/fluter pub get
denrase 9f05701
Replae input with var in flutter-test action
denrase e1bef6e
Merge branch 'main' into chore/update-gh-actions-run-vars
buenaflor fc8e4ca
Merge branch 'main' into chore/update-gh-actions-run-vars
denrase 2b287c5
fix expression
denrase 6b45781
fix run command
denrase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,10 +37,14 @@ jobs: | |
- uses: subosito/flutter-action@395322a6cded4e9ed503aebd4cc1965625f8e59a # [email protected] | ||
if: ${{ inputs.sdk == 'flutter' }} | ||
|
||
- run: ${{ inputs.sdk }} pub get | ||
- run: ${{ inputs.sdk }} pub get | ||
- run: $SDK pub get | ||
env: | ||
SDK: ${{ inputs.sdk }} | ||
- run: $SDK pub get | ||
if: ${{ inputs.package == 'flutter' }} | ||
working-directory: flutter/microbenchmarks | ||
env: | ||
SDK: ${{ inputs.sdk }} | ||
- run: dart format --set-exit-if-changed ./ | ||
|
||
- name: dart analyze | ||
|
@@ -77,10 +81,11 @@ jobs: | |
env: | ||
TOTAL: ${{ steps.analysis.outputs.total }} | ||
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }} | ||
PANA_THRESHOLD: ${{ inputs.panaThreshold }} | ||
run: | | ||
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX )) | ||
if (( $PERCENTAGE < ${{ inputs.panaThreshold }} )) | ||
if (( $PERCENTAGE < $PANA_THRESHOLD )) | ||
then | ||
echo "Score too low ($PERCENTAGE % is less than the expected ${{ inputs.panaThreshold }} %)!" | ||
echo "Score too low ($PERCENTAGE % is less than the expected $PANA_THRESHOLD %)!" | ||
exit 1 | ||
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.