Skip to content

Update GH actions run vars #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 30, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,14 @@ jobs:
- uses: subosito/flutter-action@395322a6cded4e9ed503aebd4cc1965625f8e59a # [email protected]
if: ${{ inputs.sdk == 'flutter' }}

- run: ${{ inputs.sdk }} pub get
- run: ${{ inputs.sdk }} pub get
- run: $SDK pub get
env:
SDK: ${{ inputs.sdk }}
- run: $SDK pub get
if: ${{ inputs.package == 'flutter' }}
working-directory: flutter/microbenchmarks
env:
SDK: ${{ inputs.sdk }}
- run: dart format --set-exit-if-changed ./

- name: dart analyze
Expand Down Expand Up @@ -77,10 +81,11 @@ jobs:
env:
TOTAL: ${{ steps.analysis.outputs.total }}
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
PANA_THRESHOLD: ${{ inputs.panaThreshold }}
run: |
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
if (( $PERCENTAGE < ${{ inputs.panaThreshold }} ))
if (( $PERCENTAGE < $PANA_THRESHOLD ))
then
echo "Score too low ($PERCENTAGE % is less than the expected ${{ inputs.panaThreshold }} %)!"
echo "Score too low ($PERCENTAGE % is less than the expected $PANA_THRESHOLD %)!"
exit 1
fi
4 changes: 3 additions & 1 deletion .github/workflows/diagrams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,6 @@ jobs:
# we need to pass the current branch, otherwise we can't commit the changes.
# GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
- name: Commit & push
run: ./scripts/commit-code.sh ${{ steps.extract_branch.outputs.branch }} "Update class diagrams"
run: ./scripts/commit-code.sh "$BRANCH_NAME" "Update class diagrams"
env:
BRANCH_NAME: ${{ steps.extract_branch.outputs.branch }}
3 changes: 2 additions & 1 deletion .github/workflows/flutter-symbols.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}

- run: dart run bin/flutter_symbol_collector.dart --version=${{ inputs.flutter_version || '3.*.*' }}
- run: dart run bin/flutter_symbol_collector.dart --version="$FLUTTER_VERSION"
timeout-minutes: 300
env:
GITHUB_TOKEN: ${{ github.token }}
FLUTTER_VERSION: ${{ inputs.flutter_version || '3.*.*' }}

- name: Upload updated status cache of processed files
uses: actions/upload-artifact@v4
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/flutter_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ jobs:
# Should be OK because it will likely be removed after switching to FFI (see https://github.com/getsentry/sentry-dart/issues/1444).
if: ${{ matrix.target != 'macos' }}
working-directory: ./flutter/example/${{ matrix.target }}
run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=${{ steps.device.outputs.platform }}" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO
run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=$DEVICE_PLATFORM" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO
env:
DEVICE_PLATFORM: ${{ steps.device.outputs.platform }}

test-web:
runs-on: ubuntu-latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/format-and-fix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,6 @@ jobs:
# we need to pass the current branch, otherwise we can't commit the changes.
# GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
- name: Commit & push
run: ./scripts/commit-code.sh ${{ steps.extract_branch.outputs.branch }} "Format & fix code"
run: ./scripts/commit-code.sh "$BRANCH_NAME" "Format & fix code"
env:
BRANCH_NAME: ${{ steps.extract_branch.outputs.branch }}
Loading