-
-
Notifications
You must be signed in to change notification settings - Fork 278
feat: trace connected metrics #3450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
buenaflor
wants to merge
16
commits into
main
Choose a base branch
from
feat/metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Remove addSpan method from TelemetryProcessor interface - Remove span buffer from DefaultTelemetryProcessor - Remove captureSpan method from SentryClient - Remove traceLifecycle property from SentryOptions - Remove span imports and exports - Update mocks to remove span-related code Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- trace connected metrics ([#3450](https://github.com/getsentry/sentry-dart/pull/3450))If none of the above apply, you can opt out of this check by adding |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f872f8e | 402.38 ms | 416.20 ms | 13.82 ms |
| ebccb5b | 363.79 ms | 371.10 ms | 7.31 ms |
| 75284dc | 512.39 ms | 530.87 ms | 18.48 ms |
| 2b5e090 | 437.21 ms | 467.14 ms | 29.93 ms |
| 32914d8 | 461.96 ms | 495.47 ms | 33.51 ms |
| d0aa4b6 | 395.66 ms | 393.13 ms | -2.53 ms |
| 51520fc | 351.89 ms | 349.79 ms | -2.10 ms |
| 114239b | 423.44 ms | 426.57 ms | 3.13 ms |
| 6e7d494 | 397.35 ms | 378.91 ms | -18.43 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f872f8e | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| ebccb5b | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 75284dc | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| 2b5e090 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 32914d8 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| d0aa4b6 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 51520fc | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 114239b | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 6e7d494 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0dde50 | 1268.90 ms | 1275.61 ms | 6.71 ms |
| ebccb5b | 1245.39 ms | 1249.31 ms | 3.92 ms |
| ea06d23 | 1254.02 ms | 1252.60 ms | -1.42 ms |
| 0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
| 6ad8fc4 | 1263.70 ms | 1266.06 ms | 2.36 ms |
| bbdbcb9 | 1262.70 ms | 1261.86 ms | -0.84 ms |
| e5ae2a6 | 1240.48 ms | 1253.26 ms | 12.78 ms |
| d3fb366 | 1258.29 ms | 1260.79 ms | 2.51 ms |
| 7cfee3b | 1260.90 ms | 1273.14 ms | 12.24 ms |
| 765aa8b | 1259.09 ms | 1269.90 ms | 10.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c0dde50 | 5.53 MiB | 6.01 MiB | 488.14 KiB |
| ebccb5b | 5.53 MiB | 5.96 MiB | 444.86 KiB |
| ea06d23 | 5.53 MiB | 5.96 MiB | 443.26 KiB |
| 0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ad8fc4 | 5.53 MiB | 6.01 MiB | 487.65 KiB |
| bbdbcb9 | 5.53 MiB | 6.02 MiB | 501.33 KiB |
| e5ae2a6 | 5.65 MiB | 6.09 MiB | 446.96 KiB |
| d3fb366 | 5.53 MiB | 6.01 MiB | 487.96 KiB |
| 7cfee3b | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 765aa8b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Required features first to make this complete
💡 Motivation and Context
Implements trace connected metrics
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps