Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 15, 2026

📜 Description

Required features first to make this complete

  • Android SDK 8.29.0 (previous versions dont support metrics type envelope headers)
  • Telemetry Processor
  • Telemetry Enricher

💡 Motivation and Context

Implements trace connected metrics

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

buenaflor and others added 12 commits January 14, 2026 17:43
- Remove addSpan method from TelemetryProcessor interface
- Remove span buffer from DefaultTelemetryProcessor
- Remove captureSpan method from SentryClient
- Remove traceLifecycle property from SentryOptions
- Remove span imports and exports
- Update mocks to remove span-related code

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- trace connected metrics ([#3450](https://github.com/getsentry/sentry-dart/pull/3450))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 26d0577

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.23 ms 355.31 ms -8.92 ms
Size 14.09 MiB 15.28 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f872f8e 402.38 ms 416.20 ms 13.82 ms
ebccb5b 363.79 ms 371.10 ms 7.31 ms
75284dc 512.39 ms 530.87 ms 18.48 ms
2b5e090 437.21 ms 467.14 ms 29.93 ms
32914d8 461.96 ms 495.47 ms 33.51 ms
d0aa4b6 395.66 ms 393.13 ms -2.53 ms
51520fc 351.89 ms 349.79 ms -2.10 ms
114239b 423.44 ms 426.57 ms 3.13 ms
6e7d494 397.35 ms 378.91 ms -18.43 ms
73dca78 476.53 ms 522.21 ms 45.68 ms

App size

Revision Plain With Sentry Diff
f872f8e 13.93 MiB 15.18 MiB 1.25 MiB
ebccb5b 13.93 MiB 15.18 MiB 1.25 MiB
75284dc 13.93 MiB 14.93 MiB 1.00 MiB
2b5e090 13.93 MiB 15.06 MiB 1.13 MiB
32914d8 6.54 MiB 7.70 MiB 1.16 MiB
d0aa4b6 13.93 MiB 15.18 MiB 1.25 MiB
51520fc 13.93 MiB 15.18 MiB 1.25 MiB
114239b 13.93 MiB 15.18 MiB 1.25 MiB
6e7d494 13.93 MiB 15.06 MiB 1.13 MiB
73dca78 6.54 MiB 7.69 MiB 1.15 MiB

Previous results on branch: feat/metrics

Startup times

Revision Plain With Sentry Diff
ffd9fc7 398.98 ms 399.96 ms 0.98 ms
1081ca3 384.71 ms 361.58 ms -23.13 ms

App size

Revision Plain With Sentry Diff
ffd9fc7 14.09 MiB 15.28 MiB 1.19 MiB
1081ca3 14.09 MiB 15.28 MiB 1.19 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1255.46 ms 1259.27 ms 3.81 ms
Size 5.65 MiB 6.09 MiB 450.66 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c0dde50 1268.90 ms 1275.61 ms 6.71 ms
ebccb5b 1245.39 ms 1249.31 ms 3.92 ms
ea06d23 1254.02 ms 1252.60 ms -1.42 ms
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
6ad8fc4 1263.70 ms 1266.06 ms 2.36 ms
bbdbcb9 1262.70 ms 1261.86 ms -0.84 ms
e5ae2a6 1240.48 ms 1253.26 ms 12.78 ms
d3fb366 1258.29 ms 1260.79 ms 2.51 ms
7cfee3b 1260.90 ms 1273.14 ms 12.24 ms
765aa8b 1259.09 ms 1269.90 ms 10.82 ms

App size

Revision Plain With Sentry Diff
c0dde50 5.53 MiB 6.01 MiB 488.14 KiB
ebccb5b 5.53 MiB 5.96 MiB 444.86 KiB
ea06d23 5.53 MiB 5.96 MiB 443.26 KiB
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
6ad8fc4 5.53 MiB 6.01 MiB 487.65 KiB
bbdbcb9 5.53 MiB 6.02 MiB 501.33 KiB
e5ae2a6 5.65 MiB 6.09 MiB 446.96 KiB
d3fb366 5.53 MiB 6.01 MiB 487.96 KiB
7cfee3b 20.70 MiB 22.46 MiB 1.75 MiB
765aa8b 7.86 MiB 9.44 MiB 1.58 MiB

Previous results on branch: feat/metrics

Startup times

Revision Plain With Sentry Diff
ffd9fc7 1256.04 ms 1268.54 ms 12.50 ms
1081ca3 1238.83 ms 1246.23 ms 7.40 ms

App size

Revision Plain With Sentry Diff
ffd9fc7 5.65 MiB 6.09 MiB 450.66 KiB
1081ca3 5.65 MiB 6.10 MiB 451.30 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants