Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Dependencies

- Bump Android SDK from v8.28.0 to v8.30.0 ([#3451](https://github.com/getsentry/sentry-dart/pull/3451))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8300)
- [diff](https://github.com/getsentry/sentry-java/compare/8.28.0...8.30.0)

## 9.10.0

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ android {
}

dependencies {
api 'io.sentry:sentry-android:8.28.0'
api 'io.sentry:sentry-android:8.30.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating the Android SDK disables external storage context collection by default. The Flutter integration doesn't re-enable it, which will cause integration tests to fail.
Severity: HIGH

Suggested Fix

To maintain backward compatibility and ensure tests pass, call androidOptions.setCollectExternalStorageContext(true) within the configureAndroidOptions() function. This will restore the previous behavior of collecting external storage information.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/flutter/android/build.gradle#L65

Potential issue: The update to Android SDK v8.30.0 changes the default behavior to no
longer collect external storage size information. The PR adds the necessary bindings
(`setCollectExternalStorageContext`) to control this, but fails to call
`setCollectExternalStorageContext(true)` during initialization in
`configureAndroidOptions()`. As a result, the `storage_size` and `free_storage` fields
will be missing from the device context on Android. This will cause integration tests in
`integration_test.dart`, which explicitly check for these fields, to fail. This is a
breaking change for any users who rely on this device context information.

Did we get this right? 👍 / 👎 to inform future reviews.

implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"

// Required -- JUnit 4 framework
Expand Down
Loading
Loading