Feat: Record & Send Client Reports #813

denrase · 2022-03-29T13:49:03Z

#skip-changelog

📜 Description

Integrate recorder into Transport implementations.
Record dropped events & transactions.
- Rate Limit
- Sample Rate
- Before Send
- Event Processor
Exposes void recordLostEvent(DiscardReason reason, DataCategory category) on SentryClient and Hub.

💡 Motivation and Context

Record client reports.

💚 How did you test it?

Unit tests.

📝 Checklist

🔮 Next steps

…-report # Conflicts: # dart/lib/src/client_reports/client_report_recorder.dart

codecov-commenter · 2022-03-29T14:14:37Z

Codecov Report

Merging #813 (04b8f2d) into feat/client-report-envelope-item (647fe2d) will decrease coverage by 2.71%.
The diff coverage is 85.71%.

@@                         Coverage Diff                          @@
##           feat/client-report-envelope-item     #813      +/-   ##
====================================================================
- Coverage                             92.27%   89.55%   -2.72%     
====================================================================
  Files                                    26      102      +76     
  Lines                                   777     3132    +2355     
====================================================================
+ Hits                                    717     2805    +2088     
- Misses                                   60      327     +267

Impacted Files	Coverage Δ
...rc/client_reports/noop_client_report_recorder.dart	`0.00% <0.00%> (ø)`
dart/lib/src/sentry_options.dart	`85.29% <0.00%> (ø)`
dart/lib/src/hub.dart	`80.48% <100.00%> (ø)`
dart/lib/src/sentry_client.dart	`94.73% <100.00%> (ø)`
dart/lib/src/sentry_envelope.dart	`100.00% <100.00%> (ø)`
dart/lib/src/transport/rate_limiter.dart	`95.34% <100.00%> (ø)`
flutter/lib/src/flutter_sentry_attachment.dart
...src/integrations/native_app_start_integration.dart
flutter/lib/src/sentry_native.dart
.../lib/src/navigation/sentry_navigator_observer.dart
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647fe2d...04b8f2d. Read the comment docs.

philipphofmann

Nothing to add yet. I'm looking forward to more code 😀

…-report # Conflicts: # dart/lib/src/client_reports/outcome.dart

dart/lib/src/sentry_client.dart

marandaneto · 2022-04-06T09:44:30Z

dart/lib/src/transport/http_transport.dart

@@ -19,19 +22,22 @@ class HttpTransport implements Transport {

  final RateLimiter _rateLimiter;

+  final ClientReportRecorder _clientReportRecorder;


Maybe ClientReportRecorder should be a property of SentryOptions? cc @philipphofmann

We don't put dependencies / objects to the options in ObjC. I guess you should follow your SDKs conventions and you can answer best how to follow these I think.

We don't really have a central object/place to init dependencies AFAIK, but we rather worked with singletons for now, or other objects construct their dependencies internally, like in this PR.

With the refactoring to not expose the new classes I moved the instance of ClientReportRecorder to options. It is mainly used to access the instance in Hub, SentryClient and tests.

philipphofmann

This looks pretty good 👍 . I maybe found two issues.

dart/lib/src/client_reports/discard_reason.dart

dart/lib/src/transport/rate_limiter.dart

flutter/lib/src/file_system_transport.dart

…-report # Conflicts: # dart/test/client_reports/client_report_test.dart

Denis Andrašec added 2 commits March 29, 2022 14:49

Use recorder in transport implementations

2fd4203

Merge branch 'feat/client-report-envelope-item' into feat/send-client…

e616525

…-report # Conflicts: # dart/lib/src/client_reports/client_report_recorder.dart

philipphofmann reviewed Apr 1, 2022

View reviewed changes

Denis Andrašec and others added 10 commits April 4, 2022 18:51

Merge branch 'feat/client-report-envelope-item' into feat/send-client…

92d235b

…-report # Conflicts: # dart/lib/src/client_reports/outcome.dart

add tests for http transport

e1256ae

track itme drop in rate limiter

a25f5b4

test adding of client report to envelope in file based transport

d0dabd5

track sentry client dropping event/transaction due to event processor

fc2ec5b

record events/transactions dropped by processors

16aac16

record for beforeSend

4b01a0f

record for sample rate

7bae0a3

only expose neccessary method in transport

29251ad

record lost transaction due to sample rate in hub

b680640

denrase changed the title ~~Send Client Report~~ Feat: Record & Send Client Reports Apr 6, 2022

Denis Andrašec added 2 commits April 6, 2022 11:08

revert import changes

b5f1e2e

update imports

7ffca77

denrase marked this pull request as ready for review April 6, 2022 09:17

denrase requested review from marandaneto and brustolin as code owners April 6, 2022 09:17

marandaneto reviewed Apr 6, 2022

View reviewed changes

dart/lib/src/sentry_client.dart Outdated Show resolved Hide resolved

marandaneto reviewed Apr 6, 2022

View reviewed changes

philipphofmann reviewed Apr 6, 2022

View reviewed changes

dart/lib/src/client_reports/discard_reason.dart Outdated Show resolved Hide resolved

dart/lib/src/transport/rate_limiter.dart Outdated Show resolved Hide resolved

brustolin reviewed Apr 7, 2022

View reviewed changes

flutter/lib/src/file_system_transport.dart Outdated Show resolved Hide resolved

Denis Andrašec added 5 commits April 11, 2022 10:53

Use correct data category for rate limit drop

3c59330

Mark record lost event as internal in sentry client

c246be3

fix tests on chrome

65efb0f

change structure so client reports are internal again

04b8f2d

test sendClientReports

4fc0db3

denrase requested a review from philipphofmann April 11, 2022 14:09

denrase requested a review from marandaneto April 11, 2022 14:09

Merge branch 'feat/client-report-envelope-item' into feat/send-client…

2079d9c

…-report # Conflicts: # dart/test/client_reports/client_report_test.dart

marandaneto approved these changes Apr 12, 2022

View reviewed changes

brustolin approved these changes Apr 12, 2022

View reviewed changes

denrase merged commit df0c070 into feat/client-report-envelope-item Apr 13, 2022

denrase deleted the feat/send-client-report branch April 13, 2022 07:28

denrase mentioned this pull request Apr 13, 2022

Feat: Client Reports #829

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feat: Record & Send Client Reports #813

Feat: Record & Send Client Reports #813

Uh oh!

denrase commented Mar 29, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Mar 29, 2022 •

edited

Loading

Uh oh!

philipphofmann left a comment

Uh oh!

Uh oh!

marandaneto Apr 6, 2022

Uh oh!

philipphofmann Apr 6, 2022

Uh oh!

denrase Apr 11, 2022

Uh oh!

denrase Apr 11, 2022

Uh oh!

philipphofmann left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		@@ -19,19 +22,22 @@ class HttpTransport implements Transport {

		final RateLimiter _rateLimiter;

		final ClientReportRecorder _clientReportRecorder;

Uh oh!

Feat: Record & Send Client Reports #813

Feat: Record & Send Client Reports #813

Uh oh!

Conversation

denrase commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

codecov-commenter commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marandaneto Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

philipphofmann Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

denrase Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

denrase Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

denrase commented Mar 29, 2022 •

edited

Loading

codecov-commenter commented Mar 29, 2022 •

edited

Loading