Skip to content

Conversation

sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Oct 14, 2025

DESCRIBE YOUR PR

Flutter needed types and defaults added from the SDKoption migration

Preview: https://sentry-docs-git-flutter-options-updates.sentry.dev/platforms/dart/guides/flutter/configuration/options/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 14, 2025 8:08pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 14, 2025 8:08pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 14, 2025 19:02
@sfanahata sfanahata requested review from buenaflor and stefanosiano and removed request for a team October 14, 2025 19:02
@sfanahata
Copy link
Contributor Author

@buenaflor and @stefanosiano - need your eyes on the type and default metadata added to Flutter options. I also want to point out a few places where I guessed on defaults:

  • screenshotQuality - Set to high (guessed based on typical defaults)
  • considerInAppFramesByDefault - Left without a default as the description doesn't specify one
  • anrTimeoutInterval - Set to 5000 based on "5 seconds" in description

Copy link

codecov bot commented Oct 14, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/DtF65IACX76u-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/DtF65IACX76u-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/yut_gdq4lY52bSTpqiwzW/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/yut_gdq4lY52bSTpqiwzW/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant