Skip to content

Fix PHP Monolog LogsHandler constructor in logs docs - #19640

Open
Hashim1999164 wants to merge 1 commit into
getsentry:masterfrom
Hashim1999164:fix/php-logs-monolog-handler-ctor
Open

Hashim1999164 wants to merge 1 commit into
getsentry:masterfrom
Hashim1999164:fix/php-logs-monolog-handler-ctor

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Sep 25, 2026 •

Copy link
Copy Markdown

DESCRIBE YOUR PR

Fixes #19177

The PHP logs setup snippet still constructed LogsHandler with a Hub argument. In sentry/sentry 4.x that constructor only takes a log level (and bubble), so the sample failed as written. Updated it to match the working 4.x call.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Test plan

LogsHandler in sentry/sentry 4.x only takes a level (and bubble). The
logs setup snippet still passed a Hub, so the sample could not run.
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@Hashim1999164 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Sep 25, 2026
@codeowner-assignment
codeowner-assignment Bot requested a review from a team September 25, 2026 23:11
@github-actions github-actions Bot added Priority: Normal Docs review has no urgent deadline and removed Priority: Needs Triage The PR description is missing valid priority information labels Sep 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monolog Log Handler is using old constructor parameters

1 participant