Redirect broken Node ANR event-loop-block docs URL - #19641
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
The URL .../integrations/anr/event-loop-block/ 404s because event-loop-block is a sibling of anr, not a child. Add redirects to the current eventLoopBlockIntegration docs and point the remaining relative ANR link at that page via PlatformLink. Fixes getsentry#18899
|
@SatvikMishra08 is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The Node ANR integration docs 404 when the event-loop page is requested as a child of the ANR page (
.../integrations/anr/event-loop-block/). That path should land on the currenteventLoopBlockIntegrationdocs.PlatformLinkso it uses the same destinationVerified live:
.../integrations/anr/event-loop-block/still returns 404; sibling.../integrations/event-loop-block/returns 200.Fixes #18899
IS YOUR CHANGE URGENT?
SLA
Please give the docs team up to 1 week to review.
PRE-MERGE CHECKLIST
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.