-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(nodejs): Deprecate frameContextLines
option and move to integration
#4746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@timfish is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/E3Mauqm6b4zEkxMTGuqb4oLRtc3g |
src/platforms/node/common/configuration/integrations/default-integrations.mdx
Show resolved
Hide resolved
I added the version number but now it appears to be failing on broken links for what I have added! |
:ohno: there's some anchor issues. Maybe |
It should since we run it on the built assets. @imatwawana, have you come across this before? |
Maybe I can link directly to the node docs so the link is always valid? |
I'm going to try a couple things to see if it fixes the issue. |
Generally, we want to avoid hard coded links where relative linking should work. It looks like my fix worked; there was just an extra forward slash at the end of the link that shouldn't have been there. |
Oh nice. Thank you! |
These are docs updates to cover the changes in this PR:
getsentry/sentry-javascript#3729
ContextLines
integration which has aframeContextLines
optionframeContextLines
in node options as deprecated and links to the integration