Skip to content

Document tracing-origins #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 1, 2022

@maciejwalkowiak is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@maciejwalkowiak
Copy link
Contributor Author

I am not sure if this is the right moment to merge it. Java documentation has duplicated content for configuration options:

Perhaps this should be cleaned up first.

cc @bruno-garcia @adinauer

@vercel
Copy link

vercel bot commented Apr 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/9Wdras3KK2g4n4QtfoaMEDaoYvif
✅ Preview: https://sentry-docs-git-fork-maciejwalkowiak-gh-4535.sentry.dev

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a wording suggestion

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; not sure about our plans regarding the two pages

@imatwawana
Copy link
Contributor

lgtm; not sure about our plans regarding the two pages

The Java docs have been mostly refactored, so I'm not sure why the Configuration page here isn't using the common content. Perhaps Bruno knows. IMO, if there's any time pressure about this PR, I would just merge it and log an issue for this duplication so we don't lose track of it.

@marandaneto
Copy link
Contributor

lgtm; not sure about our plans regarding the two pages

The Java docs have been mostly refactored, so I'm not sure why the Configuration page here isn't using the common content. Perhaps Bruno knows. IMO, if there's any time pressure about this PR, I would just merge it and log an issue for this duplication so we don't lose track of it.

I think the big difference is that the common options tell you that property X exists, while the other page tells you how to do it, which file to change, the format, the nuances of the flag, etc...
I also don't like duplicated stuff, but if we find a better way how to do it, I'd do in a different PR., so merging it.

@marandaneto marandaneto merged commit ff90323 into getsentry:master Apr 22, 2022
brustolin pushed a commit that referenced this pull request Apr 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants