-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document tracing-origins #4893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document tracing-origins #4893
Conversation
@maciejwalkowiak is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
I am not sure if this is the right moment to merge it. Java documentation has duplicated content for configuration options:
Perhaps this should be cleaned up first. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/9Wdras3KK2g4n4QtfoaMEDaoYvif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a wording suggestion
Co-authored-by: Isabel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; not sure about our plans regarding the two pages
The Java docs have been mostly refactored, so I'm not sure why the Configuration page here isn't using the common content. Perhaps Bruno knows. IMO, if there's any time pressure about this PR, I would just merge it and log an issue for this duplication so we don't lose track of it. |
I think the big difference is that the common options tell you that property X exists, while the other page tells you how to do it, which file to change, the format, the nuances of the flag, etc... |
No description provided.