-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ref(native): capture-error using high-level API. #5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Swatinem
merged 1 commit into
getsentry:master
from
supervacuus:ref/native-capture-error-with-high-level-api
May 30, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,30 @@ | ||
To capture an error or exception condition, create events containing an | ||
exception object. It needs to contain at least a value and type: | ||
exception object: | ||
|
||
```cpp | ||
#include <sentry.h> | ||
|
||
sentry_value_t exc = sentry_value_new_object(); | ||
sentry_value_set_by_key(exc, "type", sentry_value_new_string("Exception")); | ||
sentry_value_set_by_key(exc, "value", sentry_value_new_string("Error message.")); | ||
sentry_value_t event = sentry_value_new_event(); | ||
|
||
sentry_value_t exc = sentry_value_new_exception("Exception", "Error message."); | ||
sentry_event_add_exception(event, exc); | ||
|
||
sentry_value_t exceptions = sentry_value_new_object(); | ||
sentry_value_t values = sentry_value_new_list(); | ||
sentry_capture_event(event); | ||
``` | ||
|
||
sentry_value_set_by_key(exceptions, "values", values); | ||
sentry_value_append(values, exc); | ||
The above exception does not contain a stack trace, which must be added separately: | ||
|
||
```cpp | ||
#include <sentry.h> | ||
|
||
sentry_value_t event = sentry_value_new_event(); | ||
sentry_value_set_by_key(event, "exception", exceptions); | ||
|
||
sentry_value_t exc = sentry_value_new_exception("Exception", "Error message."); | ||
|
||
sentry_value_t stacktrace = sentry_value_new_stacktrace(NULL, 0); | ||
sentry_value_set_by_key(exc, "stacktrace", stacktrace); | ||
|
||
sentry_event_add_exception(event, exc); | ||
|
||
sentry_capture_event(event); | ||
``` | ||
|
||
This exception does not contain a stack trace, which must be added separately. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was these two which we could replace with another function:
void sentry_value_add_stacktrace(sentry_value_t, void**, size_t)
to get rid of key/entry management on the client-side, correct?