Skip to content

replay: JS CDN docs #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

replay: JS CDN docs #5932

wants to merge 3 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Dec 8, 2022 •
edited
Loading

image

See: #5894
See: #5903

@vercel
Copy link

vercel bot commented Dec 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 3:56PM (UTC)

@billyvg
Copy link
Member

billyvg commented Dec 8, 2022

@bruno-garcia what's this
image

imatwawana
imatwawana reviewed Dec 8, 2022
View reviewed changes
@bruno-garcia
Copy link
Member Author

@bruno-garcia what's this
image

Interestingly that was my review to the original PR (turns out it never went through):

image

Somehow it renders correctly on the live docs. And the snippet is the same:

image

@bruno-garcia
Copy link
Member Author

I'm missing the disclaimer that Replay is in Beta.

The CDN is already documented under Session Replay top level menu.
Moving this PR to draft right now, lets add this entry once Replay is out of beta.

@bruno-garcia bruno-garcia marked this pull request as draft December 8, 2022 20:01
@bruno-garcia
Copy link
Member Author

Lets merge this once Replay is in open beta, so anyone reading this can actually take advantage of it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@bruno-garcia bruno-garcia marked this pull request as ready for review January 16, 2023 20:16
@bruno-garcia
Copy link
Member Author

Closing it in favour of @mydea's #6088

@bruno-garcia bruno-garcia deleted the replay/bundle-cdn branch January 17, 2023 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imatwawana imatwawana imatwawana left review comments

@billyvg billyvg billyvg approved these changes

@mydea mydea Awaiting requested review from mydea

@Lms24 Lms24 Awaiting requested review from Lms24

@jas-kas jas-kas Awaiting requested review from jas-kas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruno-garcia @billyvg @imatwawana