Skip to content

Changing parent sampled flag breaks distributed traces. #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2023
Merged

Changing parent sampled flag breaks distributed traces. #7265

merged 6 commits into from
Jun 28, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jun 26, 2023 •
edited
Loading

Make it explicit, that if the parent sample decision is overridden, then distributed traces break.

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:56am

@antonpirker antonpirker mentioned this pull request Jun 26, 2023
Merged
2 tasks
sentrivana
sentrivana approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some typos, otherwise lgtm.

shanamatthews
shanamatthews approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would be more useful if we gave users more information about what breaks about distributed tracing and how they'd notice it. Can we add a sentence to both files to give that context?

@antonpirker
Copy link
Member Author

I have now also added a sentence describing what a broken trace means.

@antonpirker
Copy link
Member Author

I will be so bold and merge this, to have this off our plate.

@antonpirker antonpirker enabled auto-merge (squash) June 28, 2023 10:53
@antonpirker antonpirker merged commit e1119fe into master Jun 28, 2023
@antonpirker antonpirker deleted the antonpirker/traces-sampler-not-break-trace branch June 28, 2023 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shanamatthews shanamatthews shanamatthews approved these changes

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonpirker @shanamatthews @sentrivana