Skip to content

feat: Flush async counter#214

Merged
bruno-garcia merged 6 commits into
masterfrom
feat/flush-async-counter
May 31, 2019
Merged

feat: Flush async counter#214
bruno-garcia merged 6 commits into
masterfrom
feat/flush-async-counter

Conversation

@bruno-garcia

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented May 31, 2019

Copy link
Copy Markdown

Codecov Report

Merging #214 into master will increase coverage by 0.16%.
The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   88.48%   88.65%   +0.16%     
==========================================
  Files          81       81              
  Lines        1963     2018      +55     
==========================================
+ Hits         1737     1789      +52     
- Misses        226      229       +3
Impacted Files Coverage Δ
src/Sentry/Extensibility/HubAdapter.cs 95.45% <0%> (-4.55%) ⬇️
src/Sentry/Internal/Hub.cs 61.19% <0%> (-7.14%) ⬇️
src/Sentry/SentryClient.cs 95.06% <0%> (-1.19%) ⬇️
src/Sentry/Extensibility/DisabledHub.cs 100% <100%> (ø) ⬆️
src/Sentry/SentrySdk.cs 100% <100%> (ø) ⬆️
src/Sentry/Internal/OptionalHub.cs 76.19% <100%> (+1.19%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 95.9% <92.3%> (-2.84%) ⬇️
...Sentry/Extensibility/DiagnosticLoggerExtensions.cs 84% <0%> (+40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d17229...0b407f5. Read the comment docs.

@bruno-garcia bruno-garcia mentioned this pull request May 31, 2019

@HazAT HazAT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick

Comment thread src/Sentry/SentryClient.cs
@bruno-garcia bruno-garcia merged commit bc8b6bf into master May 31, 2019
@bruno-garcia bruno-garcia deleted the feat/flush-async-counter branch May 31, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants