Adds PublicApiAnalyzers to public projects#234
Merged
Conversation
RS0017 will show errors because some things are only available in some configurations, so I turned that warning off.
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 88.84% 88.94% +0.09%
==========================================
Files 81 81
Lines 2035 2035
==========================================
+ Hits 1808 1810 +2
+ Misses 227 225 -2
Continue to review full report at Codecov.
|
bruno-garcia
requested changes
Jun 23, 2019
bruno-garcia
left a comment
bruno-garcia
left a comment
Member
There was a problem hiding this comment.
Thanks again for contributing!
Looks good to me, just one comment about the strategy to ignore warnings.
bruno-garcia
approved these changes
Jun 24, 2019
Member
|
|
! Thanks Josh!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RE: #204
Notes:
PackageReferenceforPublicApiAnalyzersintosrcdirectory so it only shows for public projects.RS0017 (Remove deleted types and members from the declared API).SentryOptions.MaxRequestBodySize) are only declared for certain platforms, the warning will show up if it's in the.txtfile, andRS0016 (Add public types and members to the declared API)will show up if it's not, and sinceTreatWarningsAsErrorsis enabled, it breaks the build either way.