Skip to content

Fix regexes on Erlang/OTP 28 #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

josevalim
Copy link
Contributor

Regexes cannot be part of module bodies in Erlang/OTP 28, so this PR adjusts the repository accordingly.

A new release with this fix would be appreciated, since Erlang/OTP 28 has just been released. :)

@solnic solnic self-requested a review May 21, 2025 11:13
Copy link
Collaborator

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@whatyouhide whatyouhide merged commit 97d62ed into getsentry:master May 21, 2025
4 checks passed
@whatyouhide whatyouhide mentioned this pull request May 22, 2025
solnic added a commit that referenced this pull request May 27, 2025
solnic added a commit that referenced this pull request May 27, 2025
solnic added a commit that referenced this pull request May 28, 2025
* Tweak credit card regex handling for OTP-28

Just like in #889

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants