Skip to content

Fix for OTP 28 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for OTP 28 #891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edc020
Fix for OTP 28
mayel May 22, 2025
98c007d
fix typo
mayel May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/sentry/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,10 @@ defmodule Sentry.Config do
hook_opts_schema
])

@opts_schema NimbleOptions.new!(@raw_opts_schema)
@valid_keys Keyword.keys(@raw_opts_schema)

defp opts_schema, do: NimbleOptions.new!(@raw_opts_schema)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayel this is a syntax error

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry, did that quickly using github's editor. Can fix in a bit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@spec validate!() :: keyword()
def validate! do
:sentry
Expand All @@ -512,7 +513,7 @@ defmodule Sentry.Config do
|> fill_in_from_env(:release, "SENTRY_RELEASE")
|> fill_in_from_env(:environment_name, "SENTRY_ENVIRONMENT")

case NimbleOptions.validate(config_opts, @opts_schema) do
case NimbleOptions.validate(config_opts, opts_schema()) do
{:ok, opts} ->
opts
|> normalize_included_environments()
Expand Down
Loading