fix: Clone scope.Context in multiple places to avoid concurrent reads/writes #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 79.72% 79.67% -0.05%
==========================================
Files 38 38
Lines 3896 3902 +6
==========================================
+ Hits 3106 3109 +3
- Misses 681 683 +2
- Partials 109 110 +1
☔ View full report in Codecov by Sentry. |
cleptric
reviewed
May 15, 2023
cleptric
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570
Here we introduce
cloneContextthat should be used in multiple places to avoid issues like in #570.Note:
cloneContextdoes not do a deep copy ofContextvalues (which are of typeinterface{}), so there are cases where it's still possible to catch panics if you do weird things withContextvalues. But this, I believe, is out of scope of the SDK responsibility.